Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Feb 27, 2016

No description provided.

@maflcko maflcko changed the title Revert "depends: fix Boost 1.55 build on GCC 5" [depends] Revert "fix Boost 1.55 build on GCC 5" Feb 27, 2016
@maflcko maflcko changed the title [depends] Revert "fix Boost 1.55 build on GCC 5" [depends] Delete unused patches Feb 27, 2016
@jonasschnelli
Copy link
Contributor

utACK fab4e7641c7e14634a7d8f13904054d6bd608ff4
ping @theuni

@laanwj
Copy link
Member

laanwj commented Feb 29, 2016

Can you please be a bit more verbose in your commit message:

  • Why were these patches there
  • Why are they no longer needed

@maflcko
Copy link
Member Author

maflcko commented Feb 29, 2016

The patches are no longer used since 4bdad99#diff-348b8d945e85fb166a4cf611fa2e2f99L29. Also, I suspect they are bit rotten as we bumped to 1.59 already.

Edit: added to commit description

@theuni
Copy link
Member

theuni commented Mar 1, 2016

ut ACK. IIRC I back-ported these directly from boost master at the time, so dropping them in favor of a later fixed release makes sense.

@laanwj
Copy link
Member

laanwj commented Mar 1, 2016

OH I was completely misreading the diff here, due to the surprising highlighting of a second-order diff.
You're just deleting the files not removing parts of it.
utACK fafe446

@laanwj laanwj merged commit fafe446 into bitcoin:master Mar 1, 2016
laanwj added a commit that referenced this pull request Mar 1, 2016
fafe446 [depends] Delete unused patches (MarcoFalke)
@maflcko maflcko deleted the Mf1602-boost155 branch March 1, 2016 19:19
codablock pushed a commit to codablock/dash that referenced this pull request Dec 11, 2017
fafe446 [depends] Delete unused patches (MarcoFalke)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants