-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Minimal RPC & wallet support for CLTV-enabled multisig addresses #7534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "3. \"account\" (string, optional) DEPRECATED. An account to assign the addresses to.\n" | ||
| "3. options (object, optional)\n" | ||
| " {\n" | ||
| " \"cltv_height\" (numeric, optional) Minimum block height before received funds can be spent\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about cltv_time as in the createmultisig RPC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more complex. SelectCoins will need to be taught not to mix height and time locked coins, and FundTransaction to use time rather than height (preferably in more than merely cases that require it, for privacy). Note the code in this RPC call specifically blocks cltv_time for now.
| } catch (scriptnum_error) { | ||
| break; | ||
| } | ||
| // 0 CLTV is pointless, so expect at least height 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should keep OP_U32INT independent from CLTV? Allow 0 as value?
|
Concept ACK. |
|
See also #7601. |
|
Closing due to apparent lack of interest... If you want to review, poke me and I'll rebase/reopen... |
|
The concept is great, puts new BIPs to the front, if this could get more interest , could result in developers making easy use of new functionality. |
Possible next steps:
(this feature was requested on reddit)