test: script_error checking in script_invalid tests #7517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was introduced in 9fadf1c, but accidentally added in the autogenerated area.
laanwj
force-pushed
the
2016_02_test_script_errors
branch
from
f17716e to
9694b67
Compare
Member
Author
|
These are not returned in any of the script tests:
|
Check the returned script_error. Add expected script_error for generated as well as custom tests. The specific error is not part of consensus, however it could avoid unclear reporting issues such as bitcoin#6862 in the future. Fixes bitcoin#7513.
laanwj
force-pushed
the
2016_02_test_script_errors
branch
from
9694b67 to
0ecb340
Compare
Member
Author
Member
|
@laanwj Closed on purpose? I didn't see this before, but sounds like a good idea for sure. |
Member
Author
|
@theuni Closed because I've been asking for review a few times for this, but never received any answer (neither positive nor negative) so I was assuming it was too much review work relative to some extra testing coverage. Happy to reopen though! |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 4, 2016
Github-Pull: bitcoin#7517 Rebased-From: b0ff857 2317ad7 0ecb340
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the returned script_error. Add expected script_error for generated as well as custom tests.
The specific error is not part of consensus, however it could avoid unclear reporting issues such as #6862 in the future. It also makes it easier to verify that all potential error conditions are checked.
It also reveals that overflow conditions return
UNKNOWN_ERROR, there appears to be no specific error code for that.Fixes #7513.
Changes are best reviewed using
git --word-diff.