Fix quoting of copyright holders in configure.ac. #7477
Conversation
The old configure.ac did not work for a copyright holders string containing commas due to insufficient quoting. The new one allows this. While this is, of course, not of direct consequence to the current code (where the string is "Bitcoin Core"), it should still be fixed now that the string is actually factored out.
|
Note that I'm not an expert in m4, so I cannot really tell whether the fix is "correct". It just works in my trials. |
|
utACK, although this pretty much "fixes" a problem that we don't have. Derived projects with commas in their copyright string could also add the extra |
|
Seems this also makes an unrelatef change (copyright year instead of version is release)? |
|
@sipa Correct. Though I think that change makes sense -AC_DEFINE(COPYRIGHT_YEAR, _COPYRIGHT_YEAR, [Version is release])
+AC_DEFINE(COPYRIGHT_YEAR, _COPYRIGHT_YEAR, [Copyright year])Currently we get this in |
|
Yes, I agree - this is not high priority for Bitcoin. However, since we actually factored the copyright holders out, I think it makes sense to do it "correctly". True, the copyright-year change is unrelated - but I stumbled upon it while editing, and think it also makes sense and is trivial enough. But I can also remove it from the PR if you prefer. |
|
Hmm, I didn't expect multiple things in the substitution part, and the CopyrightHolders function probably won't react correctly to that. But utACK I suppose, this change shouldn't hurt. |
Right. Would make sense to have a Tested ACK here before merge. |
72fd008 Fix quoting of copyright holders in configure.ac. (Daniel Kraft)
72fd008 Fix quoting of copyright holders in configure.ac. (Daniel Kraft)
4 participants
The old configure.ac did not work for a copyright holders string containing commas due to insufficient quoting. The new one allows this. While this is, of course, not of direct consequence to the current code (where the string is "Bitcoin Core"), it should still be fixed now that the string is actually factored out.