Skip to content

[devtools] github-merge get toplevel dir without extra whitespace #7402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Jan 25, 2016
Merged

[devtools] github-merge get toplevel dir without extra whitespace #7402

laanwj merged 1 commit into from
Jan 25, 2016

Conversation

@achow101
Copy link
Member

@achow101 achow101 commented Jan 23, 2016

Fixes a bug in github merge when it runs the tests where the toplevel directory has an extra '\n' appended to the path string. Now it doesn't.

@achow101 achow101 mentioned this pull request Jan 23, 2016
Merged
@laanwj
Copy link
Member

laanwj commented Jan 25, 2016

utACK

@laanwj
Copy link
Member

laanwj commented Jan 25, 2016

Nit about commit message: please use the

Ttitle line
(empty line)
Description...

format. Otherwise everything ends up in the subject line, when viewing in git log short format (as used by #7395).

@achow101
[devtools] github-merge get toplevel dir without extra whitespace
5ed2f16 
Fixes a bug in github merge when it runs the tests where the toplevel directory has an extra '\n' appended to the path string. Now it doesn't.
@achow101
Copy link
Member Author

achow101 commented Jan 25, 2016

@laanwj fixed that and force pushed

@laanwj laanwj merged commit 5ed2f16 into bitcoin:master Jan 25, 2016
laanwj added a commit that referenced this pull request Jan 25, 2016
@laanwj
Merge #7402: [devtools] github-merge get toplevel dir without extra w…
6a5932b 
…hitespace

5ed2f16 [devtools] github-merge get toplevel dir without extra whitespace (Andrew C)
@achow101 achow101 deleted the dev-tool-fix branch January 25, 2016 14:48
codablock pushed a commit to codablock/dash that referenced this pull request Dec 9, 2017
@laanwj @codablock
Merge bitcoin#7402: [devtools] github-merge get toplevel dir without …
577f683 
…extra whitespace

5ed2f16 [devtools] github-merge get toplevel dir without extra whitespace (Andrew C)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Scripts and tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@achow101 @laanwj @jonasschnelli