Skip to content

[Qt] Add option to increase/decrease font size in the console window #7396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonasschnelli merged 3 commits into from
Jan 28, 2016
Merged

[Qt] Add option to increase/decrease font size in the console window #7396

jonasschnelli merged 3 commits into from
Jan 28, 2016

Conversation

@jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Jan 22, 2016

Allows to increase/decrease the console font size.
Font size will be persisted over QSettings (survives a restart).
Default size is unified over all platform.
Rearranged the "clear icon" and the ">" (shell prompt).

Possible future extension: allow switching between system default- and monospace-font.

bildschirmfoto 2016-01-22 um 18 00 26

@paveljanik
Copy link
Contributor

paveljanik commented Jan 22, 2016

Doesn't link here.

This was bug in my build scripts (the new files in icons/... were missing).

@paveljanik
Copy link
Contributor

paveljanik commented Jan 22, 2016

While compiling:

qt/forms/debugwindow.ui: Warning: The name 'horizontalLayout' (QHBoxLayout) is already in use, defaulting to 'horizontalLayout1'.

@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Jan 22, 2016

@paveljanik: Thanks!
Fixed the "already in use" warning and added the missing icon (travis should be happy now).

@paveljanik
Copy link
Contributor

paveljanik commented Jan 22, 2016

Works OK here.

Nits: the warning above. The tooltips contain Caps Text (Decrease _F_ont _S_ize) - compare with Clear _c_onsole.

@paveljanik
Copy link
Contributor

paveljanik commented Jan 22, 2016

@jonasschnelli IIRC icons were OK on your side - this was my local issue :-)

@jonasschnelli jonasschnelli mentioned this pull request Jan 22, 2016
Closed
@laanwj
Copy link
Member

laanwj commented Jan 22, 2016

Concept ACK, nice, this should end the complaints about the font size.

@paveljanik
Copy link
Contributor

paveljanik commented Jan 22, 2016

Concept ACK.

@achow101
Copy link
Member

achow101 commented Jan 22, 2016

Tested ACK 3a3a927

Nit: can it be done so that it doesn't jump back to the top of the window? It requires that you have to scroll all the way down if the size is changed when there is a lot of text there.

@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Jan 22, 2016

Added another commit.
Now the scroll-list keeps the vertical position (percentage) after changing the font size.

Would be nice if someone could re-test.

@achow101
Copy link
Member

achow101 commented Jan 23, 2016

Tested re-ACK 56c9e66

@paveljanik
Copy link
Contributor

paveljanik commented Jan 23, 2016

Fontsizes are OK, vertical scrollbar OK. But I do not like the cursor change (but maybe this is because I'm too old to remember real cursors ;-).

@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Jan 23, 2016

agree with @paveljanik: (re)added a Icon that indicates the promot line. Removed the placeholder text in the input field itself.
Also added copyright attributions.

@paveljanik
Copy link
Contributor

paveljanik commented Jan 23, 2016

The new icon is good :-))

@paveljanik
Copy link
Contributor

paveljanik commented Jan 24, 2016

There is "Decrease font size" tooltip over the new prompt icon (probably cut&paste issue):

screen shot 2016-01-24 at 10 27 05

@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Jan 26, 2016

Fixed the wrong tooltip on the prompt icon.
@paveljanik: mind doing a final re-test?

@paveljanik
Copy link
Contributor

paveljanik commented Jan 26, 2016

ACK jonasschnelli@43abb02

Perfect now :-)

@jonasschnelli jonasschnelli merged commit 43abb02 into bitcoin:master Jan 28, 2016
jonasschnelli added a commit that referenced this pull request Jan 28, 2016
@jonasschnelli
Merge #7396: [Qt] Add option to increase/decrease font size in the co…
cdcbc59 
…nsole window

43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli)
56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli)
3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli)
@maflcko
Copy link
Member

maflcko commented Jan 30, 2016

Awesome!
Post merge Tested ACK

@cassiniNMC cassiniNMC mentioned this pull request Apr 3, 2016
Merged
@kyuupichan kyuupichan mentioned this pull request Mar 12, 2017
Merged
cddjr referenced this pull request in cddjr/BitcoinUnlimited Apr 6, 2017
@jonasschnelli @cddjr
Merge #7396: [Qt] Add option to increase/decrease font size in the co…
06ae083 
…nsole window

43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli)
56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli)
3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli)
codablock pushed a commit to codablock/dash that referenced this pull request Sep 5, 2017
@jonasschnelli @codablock
Merge bitcoin#7396: [Qt] Add option to increase/decrease font size in…
f3a24c0 
… the console window

43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli)
56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli)
3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli)
UdjinM6 pushed a commit to dashpay/dash that referenced this pull request Sep 7, 2017
@codablock @UdjinM6
Backport Bitcoin Qt/Gui changes up to 0.14.x part 1 (#1614)
690cb58 
* Merge pull request bitcoin#7154

a3c3ddb [Qt] add InMempool() info to transaction details (Jonas Schnelli)

* Merge pull request bitcoin#7218

fa5769e [qt] Fix misleading translation (MarcoFalke)
fa8c8d7 torcontrol debug: Change to a blanket message that covers both cases (MarcoFalke)

* Merge pull request bitcoin#7255

6fd0a07 Remove hardcoded fee from CoinControl ToolTip (fanquake)
5fdf32d Replace some instances of formatWithUnit with formatHtmlWithUnit (fanquake)

* Merge pull request bitcoin#7263

a5a0831 Double semicolon cleanup. (21E14)

* Merge pull request bitcoin#7334

fa989fb [qt] coincontrol workaround is still needed in qt5.4 (fixed in qt5.5) (MarcoFalke)

* Merge pull request bitcoin#7329

9d263bd Typo fixes in comments (Chris Wheeler)

* Merge bitcoin#7396: [Qt] Add option to increase/decrease font size in the console window

43abb02 [Qt] Add a new chevron/arrow icon for the console prompt line (Jonas Schnelli)
56c9e66 [Qt] keep scroll position in GUI console after changing font size (Jonas Schnelli)
3a3a927 [Qt] Add option to increase/decrease font size in the console window (Jonas Schnelli)

* Merge bitcoin#7628: QT: Add 'copy full transaction details' option

b51ed40 QT: Add 'copy full transaction details' option (Eric Shaw)

* Merge bitcoin#7668: Fix history deletion bug after font size change

21e45a0 Fix history deletion bug after font change (Andrew C)

* Copy/Move font size related icons into theme folders

* Use formatTxDate for date/time in TxPlainTextRole
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

GUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jonasschnelli @paveljanik @laanwj @achow101 @maflcko