[Qt] rename "amount" to "requested amount" in receive coins table #7383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK |
jonasschnelli
changed the title
jonasschnelli
force-pushed
the
2016/01/qt_req_amount
branch
from
4669c96 to
6693cb2
Compare
Contributor
Author
|
Sorry. Typo. Fixed (reworded commit and PR title to "requested amount"). |
Member
|
utACK 6693cb2 |
src/qt/recentrequeststablemodel.cpp
Outdated
Member
There was a problem hiding this comment.
What about
QString RecentRequestsTableModel::getAmountTitle()
{
- QString amountTitle = tr("Amount");
if (this->walletModel->getOptionsModel() != NULL)
- {
- amountTitle += " ("+BitcoinUnits::name(this->walletModel->getOptionsModel()->getDisplayUnit()) + ")";
- }
- return amountTitle;
+ return tr("Requested") + " ("+BitcoinUnits::name(this->walletModel->getOptionsModel()->getDisplayUnit()) + ")";
+ else
+ return tr("Requested amount");
}
Member
|
utACK |
jonasschnelli
force-pushed
the
2016/01/qt_req_amount
branch
from
6693cb2 to
430674c
Compare
Contributor
Author
|
Applied @MarcoFalke diff (force push). Thanks. It's a nice solution for a smaller column. |
src/qt/recentrequeststablemodel.cpp
Outdated
Member
There was a problem hiding this comment.
I don't think we need a special translation for the case that the model is not set, it is an error case which shouldn't crash but there's no need to make translators work for it (just return empty or something like that).
Contributor
Author
There was a problem hiding this comment.
What do you think about the new solution?
jonasschnelli
force-pushed
the
2016/01/qt_req_amount
branch
from
430674c to
df6e8e1
Compare
jonasschnelli
added a commit
that referenced
this pull request
Jan 21, 2016
…ins table df6e8e1 [Qt] rename "amount" to "requested amount" in receive coins table (Jonas Schnelli)
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 9, 2017
…eive coins table df6e8e1 [Qt] rename "amount" to "requested amount" in receive coins table (Jonas Schnelli)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7014 (partial).
Users can be confused by looking at the "amount" column in the receive coins table (history or created addresses) because they expect the amount of "coins received by this address" instead of the "requested amount".
Renaming table header from "amount" to "requested amount".