devtools: replace github-merge with python version #7378
Conversation
laanwj
force-pushed
the
2016_01_python_github_merge
branch
from
340310a to
b86484c
Compare
|
Nice! Thought for future additions:
|
|
utACK b86484c |
There was a problem hiding this comment.
Could make sense to "sanitize" the title such that it fits in the git(hub) subject line.
That is, return title[0:min(80, len(title)) - len("Merge pull request #xxxx: "]
There was a problem hiding this comment.
I don't know - I don't like it cut off.
At least github tends to handle long title lines already by adding ... and continuing on the next line.
There was a problem hiding this comment.
Other, less lossy ways to shorten the text may be:
- leave out the "pull request" completely, as in "Merge During initial sync, chain download pauses if peer goes away #1234: bla"
- abbreviate it as PR
...
There was a problem hiding this comment.
ACK on keeping the full title but removing "pull request".
laanwj
force-pushed
the
2016_01_python_github_merge
branch
from
b86484c to
04bdb61
Compare
The simplest idea there would be to print the commit message for the merge to the console. It has all context information: the pull #, the pull title, and the SHA (not 256) hashes for the commits in topological order. |
This is meant to be a direct translation of the bash script,
with the difference that it retrieves the PR title from github,
thus creating pull messages like:
Merge bitcoin#12345: Expose transaction temperature over RPC
laanwj
force-pushed
the
2016_01_python_github_merge
branch
from
04bdb61 to
da6d18b
Compare
There was a problem hiding this comment.
BTW: is anyone opposed to combining 'accept' and 'sign off' into one step? I may be overlooking something, but I've never completely understood why these are separate, why you would accept a change but then not sign it (which is mandatory).
There was a problem hiding this comment.
They were separate at a time when the signing was not mandatory :)
|
Tested ACK da6d18b |
da6d18b devtools: replace github-merge with python version (Wladimir J. van der Laan)
da6d18b devtools: replace github-merge with python version (Wladimir J. van der Laan)
4 participants
This is meant to be a direct translation of the bash script.
The only major difference is that it retrieves the PR title from github, thus creating pull messages like:
[skip ci]