Skip to content

Update license year range to 2016 #7363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Jan 18, 2016
Merged

Update license year range to 2016 #7363

laanwj merged 1 commit into from
Jan 18, 2016

Conversation

@prayagverma
Copy link
Contributor

@prayagverma prayagverma commented Jan 17, 2016

No description provided.

@maflcko
Copy link
Member

maflcko commented Jan 17, 2016

Please also fix it in qt.

@prayagverma
Copy link
Contributor Author

prayagverma commented Jan 17, 2016

@MarcoFalke Sorry for my lack of information. I am unaware of what qt means

I was just passing through and saw the copyright year being not updated, therefore I made the pull request for the same.

I went through your previous commit ( 9be08b7 ) and have updated my pull request accordingly.

If this isn't what you meant, if you can point me in the direction of what needs to be done, then I would surely do that

@maflcko
Copy link
Member

maflcko commented Jan 17, 2016

Qt is our GUI framework. Please look at edbc904

@prayagverma
Copy link
Contributor Author

prayagverma commented Jan 17, 2016

@MarcoFalke Thanks for guiding. I have updated the pull request with the changes you suggested

@laanwj
Copy link
Member

laanwj commented Jan 18, 2016

Yes we should get rid of the duplication between clientversion.h and configure.ac some time. Note that this has nothing to do with qt.

@laanwj
Copy link
Member

laanwj commented Jan 18, 2016

utACK

@laanwj laanwj added the Docs label Jan 18, 2016
@laanwj laanwj merged commit bd34174 into bitcoin:master Jan 18, 2016
laanwj added a commit that referenced this pull request Jan 18, 2016
@laanwj
Merge pull request #7363
2350ab2 
bd34174 Update license year range to 2016 (Prayag Verma)
laanwj pushed a commit that referenced this pull request Jan 18, 2016
@prayagverma @laanwj
Update license year range to 2016
098fcb5 
Conflicts:
	configure.ac

Github-Pull: #7363
Rebased-From: bd34174
@maflcko
Copy link
Member

maflcko commented Jan 18, 2016

Our qt GUI is the most prominent sink of COPYRIGHT_YEAR.

@maflcko
Copy link
Member

maflcko commented Jan 18, 2016

post merge utACK bd34174

@pra85 Thanks for sticking with this.

@prayagverma
Copy link
Contributor Author

prayagverma commented Jan 18, 2016

I am glad that I could be helpful in some way 😄

@laanwj
Copy link
Member

laanwj commented Jan 18, 2016

Our qt GUI is the most prominent sink of COPYRIGHT_YEAR.

Yes, but see the #if defined(HAVE_CONFIG_H). COPYRIGHT_YEAR comes from config/bitcoin-config.h.
Effectively, at least for build configurations that we support, the content of clientversion.h will never be used.
The duplication is there as an old crutch to support building without autotools. But there have been so many additions to bitcoin-config.h and platform detection over the last versions that this has become unrealistic anyway.

@ghost ghost mentioned this pull request Jan 23, 2017
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prayagverma @maflcko @laanwj