Skip to content

[trivial] fixing multiple typos #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Jan 18, 2016
Merged

[trivial] fixing multiple typos #7313

laanwj merged 1 commit into from
Jan 18, 2016

Conversation

@calebogden
Copy link

@calebogden calebogden commented Jan 8, 2016

No description provided.

@calebogden calebogden changed the title Found and fixed some typos [trivial] fixing multiple typos Jan 8, 2016
@paveljanik
Copy link
Contributor

paveljanik commented Jan 8, 2016

ACK after squashing into one commit.

@dcousens
Copy link
Contributor

dcousens commented Jan 8, 2016

trivial ACK @ f85d3d7, please squash

@fanquake
Copy link
Member

fanquake commented Jan 8, 2016

Nack as is. If you are going to correct them please fix them all. From torcontrol.cpp

    connected is the handler that is called when connection is succesfully established.      [position 82:67]   
    LogPrint("tor", "tor: Succesfully connected!\n");      [position 180:31]    
    Callback after succesful connection      [position 383:24]  
    LogPrint("tor", "tor: ADD_ONION succesful\n");      [position 422:41]   
    LogPrint("tor", "tor: Authentication succesful\n");      [position 451:46]  
    LogPrint("tor", "tor: SAFECOOKIE authentication challenge succesful\n");      [position 504:67]

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jan 8, 2016

agree with @fanquake: would be nice to fix all of them.
Once fixed, ACK after squashing.

@calebogden
Copy link
Author

calebogden commented Jan 8, 2016

@fanquake @jonasschnelli Ah yeah I thought I grabbed those too, fixed!

@maflcko
Copy link
Member

maflcko commented Jan 8, 2016

utACK 0331aa3

1 similar comment
@dcousens
Copy link
Contributor

dcousens commented Jan 9, 2016

utACK 0331aa3

@paveljanik
Copy link
Contributor

paveljanik commented Jan 9, 2016

trivial ACK 0331aa3

@fanquake
Copy link
Member

fanquake commented Jan 16, 2016

ACK 0331aa3

@laanwj laanwj merged commit 0331aa3 into bitcoin:master Jan 18, 2016
laanwj added a commit that referenced this pull request Jan 18, 2016
@laanwj
Merge pull request #7313
5e00147 
0331aa3 Fixing typos on security-check.py and torcontrol.cpp (calebogden)
@calebogden calebogden deleted the patch-1 branch January 19, 2016 19:34
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Feb 12, 2016
@calebogden @luke-jr
Fixing typos on security-check.py and torcontrol.cpp
d68de7a 
Github-Pull: bitcoin#7313
Rebased-From: 0331aa3
@str4d str4d mentioned this pull request Mar 24, 2017
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Mar 26, 2017
@zkbot
Auto merge of #2177 - str4d:2061-tor-ephemeral-hs, r=daira
45faa92 
Tor ephemeral hidden services

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6503 (included to reduce merge conflicts)
- bitcoin/bitcoin#6639
- bitcoin/bitcoin#6643
- bitcoin/bitcoin#7090
- bitcoin/bitcoin#7035
- bitcoin/bitcoin#7170
- bitcoin/bitcoin#7218 (non-QT part)
- bitcoin/bitcoin#7313
- bitcoin/bitcoin#7438
- bitcoin/bitcoin#7553
- bitcoin/bitcoin#7637
- bitcoin/bitcoin#7683
- bitcoin/bitcoin#7813
- bitcoin/bitcoin#7703
- bitcoin/bitcoin#8203
- bitcoin/bitcoin#9004
- bitcoin/bitcoin#9234
- bitcoin/bitcoin#9911 (partial)

Closes #2061.
@kyuupichan kyuupichan mentioned this pull request Apr 9, 2017
Merged
codablock pushed a commit to codablock/dash that referenced this pull request Dec 9, 2017
@laanwj @codablock
Merge pull request bitcoin#7313
3808025 
0331aa3 Fixing typos on security-check.py and torcontrol.cpp (calebogden)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@calebogden @paveljanik @dcousens @fanquake @jonasschnelli @maflcko @laanwj