qt5: Use the fixed font the system recommends #7214
Conversation
|
@jonasschnelli Mind to create binaries? |
|
Great, will try this soon: https://bitcoin.jonasschnelli.ch/pulls/7214/ ... Looks like this does not change anything. |
|
@MarcoFalke I don't have a problem with the current code, and I don't use Qt5... |
|
Concept ACK, although I'd expect <pre> already does this |
|
@laanwj Good point... <pre> would likely be Qt4-compatible too. Has anyone tried this? |
|
I think I already tried < pre > in #6864 |
It looks like this does not fix any bug or change the behavior. We could as well just close this PR, but I don't have a strong opinion here. |
|
Looks much better on OSX now: Current Master This PR: Will test on Linux/Windows soon. |
I think I did this and could not find a difference. |
|
Tested ACK fa2f4bc
|
fa2f4bc qt5: Use the fixed font the system recommends (MarcoFalke)
Github-Pull: bitcoin#7214 Rebased-From: fa2f4bc
Github-Pull: bitcoin#7214 Rebased-From: fa2f4bc
Github-Pull: bitcoin#7214 Rebased-From: fa2f4bc
4 participants
Guess it can't hurt to use the system recommendation in
fixedPitchFont(). This may even provide a workaround for #7017.http://doc.qt.io/qt-5/qfontdatabase.html#systemFont was introduced in Qt 5.2.