rpc: remove cs_main lock from createrawtransaction
#7156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pure utility function that doesn't use main's data structures, so it does not require that lock.
Contributor
|
Code Review utACK. Can't find any unguarded deeper structure either. |
Contributor
|
ACK |
Contributor
|
|
Contributor
|
utACK I couldn't find any unguarded paths. |
Contributor
|
ACK |
Member
|
utACK |
laanwj
added a commit
that referenced
this pull request
Dec 11, 2015
6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Dec 28, 2015
This is a pure utility function that doesn't use main's data structures, so it does not require that lock. Github-Pull: bitcoin#7156 Rebased-From: 6e76587
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Dec 28, 2015
This is a pure utility function that doesn't use main's data structures, so it does not require that lock. Github-Pull: bitcoin#7156 Rebased-From: 6e76587
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 26, 2016
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Dec 9, 2017
6e76587 rpc: remove cs_main lock from `createrawtransaction` (Wladimir J. van der Laan)
LarryRuane
pushed a commit
to LarryRuane/zcash
that referenced
this pull request
Feb 19, 2021
This is a pure utility function that doesn't use main's data structures, so it does not require that lock. zcash: cs_main still needed while calling chainActive() zcash: cherry picked 6e76587 zcash: bitcoin/bitcoin#7156
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 19, 2021
Bitcoin 0.12 locking PRs These are locking changes from upstream (bitcoin core) release 0.12. - bitcoin/bitcoin#7013 - bitcoin/bitcoin#7156 - bitcoin/bitcoin#7229
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues work to remove/push down RPC locks from #7013.
createrawtransactionis a pure utility function that doesn't use main's data structures, so it does not require that lock.Despite being a one-line change, needs to be reviewed carefully. Although I didn't find any, there may be unguarded use of main data structures deeper in the call chain. Not meant for 0.12