Bugfix: Correctly calculate priority when inputs are mined after dependent transactions enter the memory pool #7149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
luke-jr
force-pushed
the
bugfix_priority
branch
from
8b9b55c to
e940e4d
Compare
Member
Author
|
Added RPC tests and fixed an additional bug found with them. This should now be ready for merging to master and 0.12. |
Member
|
Weak concept NACK. I don't think we should be spending effort on maintaining the old priority system (which was completely arbirary anyway). |
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 27, 2016
…of a transaction in the mempool
Track the value of inputs that get confirmed in the chain and keep a cached value of priority at a given height and return current priority by only assuming these in chain inputs are aging.
…nd currentpriority - Since the transaction arrives after block N, its starting priority is that for block N+1. - The current priority is likewise as considered for mining the next block.
…heir mempools may not sync, so only sync blocks
… is not guaranteed to work
luke-jr
force-pushed
the
bugfix_priority
branch
from
887fc24 to
ae93a95
Compare
Member
|
Closing this due to inactivity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to restore proper CreateNewBlock functioning for unconfirmed transaction chains.