-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Name union to prevent compiler warning #7146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name union to prevent compiler warning #7146
Conversation
|
ACK |
|
But if you're going to give it a name anyway, better make it a descriptive one, like "direct_or_indirect"? |
|
I was about to use |
|
ACK once it uses a proper name. |
|
@jonasschnelli And do you have an opinion the correct name? Do you agree with |
Better than |
f05f2d0 to
1812de9
Compare
|
|
|
ACK 1812de9 |
|
OK, thanks for your opinions. Name update. |
|
utACK 1812de9 mod travis |
|
|
1812de9 Name union to prevent compiler warning (Pavel Janík)
…zation 30e975e Lift prevector default vals to the member declaration (random-zebra) 3217b2b Name union to prevent compiler warning (random-zebra) Pull request description: Two simple additions to `prevector` class: - name the union, to prevent compiler warnings emitted by clang (from bitcoin#7146) - use non-static data member initializers for `_size` and `_union` (from bitcoin#14266) ACKs for top commit: furszy: utACK 30e975e Fuzzbawls: utACK 30e975e Tree-SHA512: f7a0dd55bbf2df0b9d0d72967ac00c476aebde936499cd3d1b5a7552aded6b7022c5a23c859eaa3599875f2c2c7bd737afdda3cd31db9d7e2c5dfdca7f0c9809
After merging #6914, a lot of compiler warnings are emitted by
clang: