[Trivial] Move time data log print to 'net' category to reduce noise #7075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulip0
changed the title
Contributor
|
utACK |
Member
There was a problem hiding this comment.
Will this look weird when we decide to auto print the category?
Author
There was a problem hiding this comment.
Yes, it'll need fixing if that change is made in the future.
Does anybody run in the non-specific -debug mode that would require this?
2015-11-23 08:06:14 Added time data, samples 5, offset -1 (+0 minutes)
2015-11-23 08:06:14 -1 -1 -1 +0 +0 | nTimeOffset = -1 (+0 minutes)
Maybe that second print can go away entirely? The utility for debugging seems low.
Member
There was a problem hiding this comment.
Will this look weird when we decide to auto print the category?
Not if we stick with a strict format, and only print the category name on new lines along with the time.
Outputting something using multiple PrintX calls has always been possible, and should still be possible after that (currently purely theoretical) change.
Member
|
Good idea, utACK |
laanwj
added a commit
that referenced
this pull request
Nov 24, 2015
4846543 Move time data log print to 'net' category to reduce log noise (tulip)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Feb 19, 2021
Bitcoin 0.12 misc P2P/Net PRs Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5288 - Only the reorg, option was removed in bitcoin/bitcoin#6374 which we merged in #1258 - bitcoin/bitcoin#6561 - bitcoin/bitcoin#6728 - bitcoin/bitcoin#6829 - bitcoin/bitcoin#6974 - bitcoin/bitcoin#7075 - bitcoin/bitcoin#7166 Part of #2074.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On every peer connection Bitcoin Core prints timestamp offset information to the main log, this adds noise and has little utility. This patch moves it to the "net" debug category instead.