Fixed integer comparison warning. #7023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
This is obviously the smaller change, but, couldn't nLastBlockFile just be unsigned?
Contributor
Author
There was a problem hiding this comment.
I think it could - but that would require having to check whether that breaks anything...and if we're going down that route, we could also start changing a bunch of other variables...and I don't think I want to go down that path right now :)
Member
|
ACK. I don't think nLastBlockFile can be usefully negative, but this is clearly the least risky change. |
Contributor
|
ACK The warning comes from #6948. |
Contributor
|
ACK. |
gmaxwell
added a commit
that referenced
this pull request
Nov 17, 2015
4d29032 Fixed integer comparison warning. (Eric Lombrozo)
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Nov 18, 2015
Github-Pull: bitcoin#7023 Rebased-From: 4d29032
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Dec 8, 2015
Github-Pull: bitcoin#7023 Rebased-From: 4d29032
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit typecast to remove compiler warning.