Skip to content

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Nov 13, 2015

I've collected these over time, mostly adding notes after troubleshooting obscure bugs. As I hope to get the community more involved in the whole process, I think it is useful to add to the developer-notes.

I've collected these over time, mostly adding notes after
troubleshooting obscure bugs. As I hope to get the community more
involved in the whole process, I think it is useful to add to the
developer-notes.
@laanwj laanwj added the Docs label Nov 13, 2015
@jonasschnelli
Copy link
Contributor

Nice. I think this is very helpful for new devs (and even for old hands).

I would say we should take these new point directly at the 2nd position above of "doxygen comments".

@paveljanik
Copy link
Contributor

These are gems! Thank you for collecting all these notes. They help a lot!

@petertodd
Copy link
Contributor

Awesome, thanks!

@paveljanik I'd prefer dots at the end of sentences too.

ACK

@gmaxwell
Copy link
Contributor

ACK (with or without my suggestions), this is all good stuff.

@sipa
Copy link
Member

sipa commented Nov 14, 2015 via email

@gavinandresen
Copy link
Contributor

ACK. Very nice!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor nitpick: instead 'pulls', should we make it 'pull requests' ?

@omefire
Copy link

omefire commented Nov 15, 2015

Thanks, these are helpful, especially for folks like me, ramping up on the codebase and planning to start contributing code.

@sipa sipa merged commit b8c06ef into bitcoin:master Nov 28, 2015
sipa added a commit that referenced this pull request Nov 28, 2015
b8c06ef doc: Add non-style-related development guidelines (Wladimir J. van der Laan)
@sipa
Copy link
Member

sipa commented Nov 28, 2015

@onefire Reasonable nits, but no reason to hold this up, IMHO. Feel free to submit improvements.

@paveljanik
Copy link
Contributor

@onefire While doing so, please fix also the nits I brought. Thank you.

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants