-
Notifications
You must be signed in to change notification settings - Fork 38.6k
doc: Add non-style-related development guidelines #7003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've collected these over time, mostly adding notes after troubleshooting obscure bugs. As I hope to get the community more involved in the whole process, I think it is useful to add to the developer-notes.
|
Nice. I think this is very helpful for new devs (and even for old hands). I would say we should take these new point directly at the 2nd position above of "doxygen comments". |
|
These are gems! Thank you for collecting all these notes. They help a lot! |
|
Awesome, thanks! @paveljanik I'd prefer dots at the end of sentences too. ACK |
|
ACK (with or without my suggestions), this is all good stuff. |
|
Very ACK.
|
|
ACK. Very nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor nitpick: instead 'pulls', should we make it 'pull requests' ?
|
Thanks, these are helpful, especially for folks like me, ramping up on the codebase and planning to start contributing code. |
b8c06ef doc: Add non-style-related development guidelines (Wladimir J. van der Laan)
|
@onefire Reasonable nits, but no reason to hold this up, IMHO. Feel free to submit improvements. |
|
@onefire While doing so, please fix also the nits I brought. Thank you. |
I've collected these over time, mostly adding notes after troubleshooting obscure bugs. As I hope to get the community more involved in the whole process, I think it is useful to add to the developer-notes.