utACK

Same sample output to judge the formatting:

There are two { on uploadtarget line and missing commas after t...

Boolean entries are described differently in the other help texts.

Thanks for the review.
Fixed the double "{" and the description for the booleans.

The output here looks like this:

{
  "totalbytesrecv": 7718519,
  "totalbytessent": 56670,
  "timemillis": 1447337892394,
  "uploadtarget": {
    "timeframe": 86400,
    "target": 0,
    "target_reached": false,
    "serve_historical_blocks": true,
    "bytes_left_in_cycle": 0,
    "time_left_in_cycle": 0
  }
}

Please note the position of { in uploadtarget - it is on the same line. Can you move it there also in the helptext?

And this was the last nit.

ACK

Would it hurt just to add "bytes" to "target"? aka "targetbytes"
Everything else has bytes in the field name.

nit aside, utACK

Meta-comment: if #6984 gets merged I'd want to know that whitelisted peers existed and I was serving historical blocks to them.

Would it hurt just to add "bytes" to "target"? aka "targetbytes"
Everything else has bytes in the field name.

Hah, yes, we could comment many things on consistency in the RPC interface. Some things have _ separators some have words written together, there are even a few camelCases here and there.

Only if it isn't in a release yet there is still scope for changing it.

@jonasschnelli Thanks for documenting it though - as it is.

utACK

ACK.

ACK