Fix CCoins serialization documentation #6942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs talk about bits 2 and 4 instead of 2 and 3, and bits are being indexed from both 1 (describing nCode) and 0 (in second example). Changed to use zero-indexing for all.
Member
|
The documentation is intended to say "bits with value 1, 2, 4, ...", not
their position.
|
Contributor
Author
|
Ah, that makes sense. I thought I must be missing something. It still doesn't seem very clear to me though - the second example describes "bits 2 (0x04) and 14 (0x4000)". |
Member
|
Agree, that's confusing. Feel free to rewrite into something clearer :)
|
Member
|
I also got confused by the bit notation but the text is correct (clarification would be welcome, absolutely). |
sipa
added a commit
that referenced
this pull request
Nov 28, 2015
e482a7f Fix CCoins serialization documentation (Peter Josling)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs talk about bits 2 and 4 instead of 2 and 3, and bits are being indexed from both 1 (describing nCode) and 0 (in second example). Changed to use zero-indexing for all.