Remove BIP30 enforcement, as it is impossible to trigger since BIP34 #6916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BIP34 guarantees that every coinbase transaction (and thus every transaction derived from it) has a unique txid, assuming no double-SHA256 collisions. Alex Morcos discovered that BIP30 verification always requires access to the database underlying the chainstate cache, as we don't do negative caching. As BIP30 is the only thing that would need such a negative cache in consensus logic, better to just remove it.
Contributor
|
How does this avoid corruption during initial block download? I give you a run of early blocks that perform overwrites prior to BIP34; eventually you discover that chain is shorter than the good one and try to reorganize it out. Oops: You can't. |
Member
Author
|
Oops. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIP34 guarantees that every coinbase transaction (and thus every transaction derived from it) has a unique txid, assuming no double-SHA256 collisions.
@morcos discovered that BIP30 verification always requires access to the database underlying the chainstate cache, as we don't do negative caching. As BIP30 is the only thing that would need such a negative cache in consensus logic, better to just remove it.