Chainparams: DRY: Make qt/guiutil.cpp fit BIP70 chain name strings #6908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Contributor
|
utACK |
src/qt/guiutil.cpp
Outdated
Member
There was a problem hiding this comment.
This is not backwards compatible. The problem is that a startup link for testnet may already have been created. The scenario that the user enables testnet link at startup, upgrades, and then they cannot disable it anymore because it deletes a different link.
…ings As a side effect, the qt user will see "test" instead of "testnet"
jtimon
force-pushed
the
chainparams-bip70-0.12.99
branch
from
7718d3b to
c53d48a
Compare
Contributor
Author
|
Good catch @laanwj . I hopefully fixed it. |
Member
|
Looks good to me now. utACK |
Member
|
utACK |
laanwj
added a commit
that referenced
this pull request
Nov 9, 2015
c53d48a BIP70: Chainparams: DRY: Make qt/guiutil.cpp fit BIP70 chain name strings (Jorge Timón)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a side effect, the qt user will see "test" instead of "testnet".
This simplifies creating new testchains by not having to introduce a new special case with each chain in this part of the code. The resulting code is also less redundant and shorter even with only 2 testchains.
Part of #6382