Skip to content

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Oct 23, 2015

  • Add developer notes about .gitignore.
  • Remove qt creator specific files from gitignore, to be consistent

Context: discussion in #6813, this is a bit of a FAQ so worth mentioning.

@btcdrak
Copy link
Contributor

btcdrak commented Oct 23, 2015

Good.

You should mention the simple command line however which does most of the hard work as per https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

@dexX7
Copy link
Contributor

dexX7 commented Oct 23, 2015

Thanks for the information, very helpful!

@fanquake
Copy link
Member

ACK

@jonasschnelli
Copy link
Contributor

ACK.

- Add developer notes about `.gitignore.`
- Remove qt creator specific files from gitignore, to be consistent.
@laanwj laanwj force-pushed the 2015_10_ignore_files branch from cf45f8b to dca7bd3 Compare October 23, 2015 12:24
@laanwj
Copy link
Member Author

laanwj commented Oct 23, 2015

You should mention the simple command line however which does most of the hard work as per https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

Added a mention of that - personally I prefer editing the config file manually, instead of memorizing the command, don't think it's very hard work :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fairly standard practice in open-source environments... (Not saying we have to do it, but this description isn't correct.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experience in - much more heterogeneous, multiplatform - open source projects it's rare to see ignores for specific tools that some of the developers use

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the point is that ignore files should always be specific to the project, and not to the developer's environment. So IDE files for example should always be in the user's own gitignore and not the project source's.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking things like *~

@petertodd
Copy link
Contributor

ACK

@maflcko
Copy link
Member

maflcko commented Oct 24, 2015

ACK .gitignore diff

Meh, "doesn't hurt" on the dev notes.

@laanwj laanwj merged commit dca7bd3 into bitcoin:master Oct 26, 2015
laanwj added a commit that referenced this pull request Oct 26, 2015
dca7bd3 doc: Add developer notes about gitignore (Wladimir J. van der Laan)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants