[Trivial] Use constants for DB keys #6823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace literal occurances of the key "prefixes" 'c' and 'b' in txdb.cpp by the respective constants.
Member
|
utACK |
Contributor
|
ACK |
1 similar comment
Contributor
|
ACK |
Member
|
utACK |
Member
|
ACK |
Member
|
I don't get it, why wasn't this done when the constants were introduced? utACK, checked that the values match |
laanwj
added a commit
that referenced
this pull request
Oct 15, 2015
f8f2ace trivial: use constants for db keys (Daniel Kraft)
Contributor
Author
|
I think it was, but the recent iterator patch may have used the literals instead of the constants; that's my guess, but I'm not motivated to check it. |
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Jan 15, 2018
Bitcoin 0.12+ dbwrapper improvements Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6650 - Only refactor - excludes obfuscation - bitcoin/bitcoin#6777 - Excluding obfuscation-related changes - bitcoin/bitcoin#6865 - bitcoin/bitcoin#6823 - bitcoin/bitcoin#6873 - bitcoin/bitcoin#7927 - Excluding first commit (already included) and second commit (obfuscation-related) - bitcoin/bitcoin#8467 Part of #2074.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Apr 3, 2018
Bitcoin 0.12+ dbwrapper improvements Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6650 - Only refactor - excludes obfuscation - bitcoin/bitcoin#6777 - Excluding obfuscation-related changes - bitcoin/bitcoin#6865 - bitcoin/bitcoin#6823 - bitcoin/bitcoin#6873 - bitcoin/bitcoin#7927 - Excluding first commit (already included) and second commit (obfuscation-related) - bitcoin/bitcoin#8467 Part of #2074.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace literal occurances of the key "prefixes" 'c' and 'b' in txdb.cpp by the respective constants.