utACK

utACK

Please clean up class/struct Params:

src pavel$ grep "[class|strict] Params" consensus/*h
consensus/params.h:struct Params {
consensus/softforks.h:class Params;
src pavel$ 

@paveljanik @dcousens Fixed class->struct

Apart from my bike-shedding nits, ut ACK.

I changed my mind about this. I prefer something like jtimon@8ec8241 again.
NACK
In any case rebase or close?

@jtimon why do you prefer it?

Still utACK from me, but needs rebase

It's simpler and achieves the task of encapsulating consensus code more simply (although of course this is relative). I don't think a UseRule() function is interesting getting the consensus validation flags that include those rules (and I would unify other future consensus flags [like the one for bip113] with the script ones too).

Sorry, that was a mistake, I thought I was talking on #6747 . This is just a tiny and pointless moveonly IMO.
Instead of this, I would prefer something like this jtimon@f8c34f2 (see https://github.com/jtimon/bitcoin/commits/libconsensus-f2 for the "big picture" and #7091 for the pre-document-with-words-and-pictures opened first step).

@dcousens Rebasing - will push shortly. #6747 that is, not this one.

I think we can close this now. Also I recall talk of replacing the ISM checks with block heights.