Skip to content

Conversation

@petertodd
Copy link
Contributor

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dot after parens?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm? What specifically do you think I should change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-constant opcodes. (OP_1 to OP_16)
+constant opcodes (OP_1 to OP_16).

ie. move the dot at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Sorry. Fixed.

@petertodd petertodd force-pushed the pull-req-6424-release-notes branch from 2817dc9 to c66472b Compare October 3, 2015 16:21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here. Sorry, I haven't seen it at first somehow.

@jonasschnelli
Copy link
Contributor

ACK.

But I really would like to see git commit title/description understandable from a non github perspective. Keeping the mindset decentralized even at the place where the source code is managed is probably a good thing.

As @laanwj once mentioned, the issue/PR number within a commit title/description is okay. But still it should be understandable from a non GitHub perspective.

@luke-jr
Copy link
Member

luke-jr commented Oct 3, 2015

+1 on a readable commit message.

@petertodd
Copy link
Contributor Author

@jonasschnelli Sure, tell me what you want it to be and I'll make it that.

@paveljanik
Copy link
Contributor

What about: Mention now allowed sequence of pushdatas in OP_RETURN outputs in release notes.

@laanwj laanwj added the Docs label Oct 5, 2015
Mention now allowed sequence of pushdatas in OP_RETURN outputs in
release notes.
@petertodd petertodd force-pushed the pull-req-6424-release-notes branch from c66472b to 9204930 Compare October 5, 2015 22:13
@petertodd
Copy link
Contributor Author

@paveljanik done

@laanwj laanwj merged commit 9204930 into bitcoin:master Oct 6, 2015
laanwj added a commit that referenced this pull request Oct 6, 2015
9204930 Document pull-req #6424 in release-notes (Peter Todd)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants