-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Document pull-req #6424 in release-notes #6751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
doc/release-notes.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dot after parens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm? What specifically do you think I should change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-constant opcodes. (OP_1 to OP_16)
+constant opcodes (OP_1 to OP_16).
ie. move the dot at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Sorry. Fixed.
2817dc9 to
c66472b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same here. Sorry, I haven't seen it at first somehow.
|
ACK. But I really would like to see git commit title/description understandable from a non github perspective. Keeping the mindset decentralized even at the place where the source code is managed is probably a good thing. As @laanwj once mentioned, the issue/PR number within a commit title/description is okay. But still it should be understandable from a non GitHub perspective. |
|
+1 on a readable commit message. |
|
@jonasschnelli Sure, tell me what you want it to be and I'll make it that. |
|
What about: Mention now allowed sequence of pushdatas in OP_RETURN outputs in release notes. |
Mention now allowed sequence of pushdatas in OP_RETURN outputs in release notes.
c66472b to
9204930
Compare
|
@paveljanik done |
No description provided.