-
Notifications
You must be signed in to change notification settings - Fork 38.6k
[wallet] Adjust MIN_CHANGE #6696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ab22098 to
979cf1b
Compare
|
The test failure is on the Windows build, and unrelated |
979cf1b to
d2f140d
Compare
|
hmm, i'd suggest that perhaps MIN_CHANGE could depend on the input amounts? |
|
The tests assume that the minimum change is static, so they'd need to be adjusted as well if the minimum change now depends on the target value. |
|
The current Also I'm not sure if coupling it with I tend to keep the value high to prevent from creating dusty outputs (assume fees are rising). |
|
I created this pull to see what other opinions exist. Basically, changing the defaults to work around bugs is not the right way. Instead the wallet code should select coins more intelligent to prevent large transactions and also prevent combining inputs from many different addresses. |
|
A one-line adjustment for 0.12 with something like I plan to address the wallet code changes until 0.13 or 0.14. |
Agree. But not sure about 0.12. Rc1 is already out and we might want to keep the existing MIN_CHANGE behavior in 0.12. |
d2f140d to
fae5ea4
Compare
|
I will think about this and open a new pull next week. |
According to recent exchange rates avoiding change of some value between 1 and 10 USD is no longer reasonable: E.g. a bunch of people tipped me .35 USD. Whenever I want to send those tips, the transaction includes 7 of them just to send back to me.