Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Sep 18, 2015

According to recent exchange rates avoiding change of some value between 1 and 10 USD is no longer reasonable: E.g. a bunch of people tipped me .35 USD. Whenever I want to send those tips, the transaction includes 7 of them just to send back to me.

@laanwj laanwj added the Wallet label Sep 21, 2015
@maflcko maflcko force-pushed the MarcoFalke-2015-walletFixMinChange branch 2 times, most recently from ab22098 to 979cf1b Compare November 4, 2015 12:34
@maflcko maflcko changed the title [wallet] Adjust nMinChange [wallet] Adjust MIN_CHANGE Nov 4, 2015
@fanquake
Copy link
Member

The test failure is on the Windows build, and unrelated

WARNING: The following packages cannot be authenticated!
  liblcms2-2 liblcms2-2 wine1.7-amd64 wine1.7-i386 wine1.7
E: There are problems and -y was used without --force-yes
The command "sudo apt-get install --no-install-recommends --no-upgrade -qq nsis gcc-mingw-w64-x86-64 g++-mingw-w64-x86-64 binutils-mingw-w64-x86-64 mingw-w64-dev wine1.7 bc" failed. Retrying, 3 of 3.

@maflcko maflcko force-pushed the MarcoFalke-2015-walletFixMinChange branch from 979cf1b to d2f140d Compare November 12, 2015 21:11
@morcos
Copy link
Contributor

morcos commented Dec 10, 2015

hmm, i'd suggest that perhaps MIN_CHANGE could depend on the input amounts?
otherwise it seems like this might be too drastic a change.

@maflcko
Copy link
Member Author

maflcko commented Dec 16, 2015

The tests assume that the minimum change is static, so they'd need to be adjusted as well if the minimum change now depends on the target value.

@jonasschnelli
Copy link
Contributor

The current MIN_CHANGE is 1000000 bits (0.01 BTC) and I agree that this is relatively high.
This change would reduce the static MIN_CHANGE to 1000 bits (0.00001) which is to low IMO and might result in dust/uneconomic inputs.

Also I'm not sure if coupling it with DEFAULT_TRANSACTION_MINFEE (or other fee relevant vars) is the right thing, because it's unknown when the change output will be used as input (1-2 years)?

I tend to keep the value high to prevent from creating dusty outputs (assume fees are rising).
But maybe I'm looking at it from the wrong perspective. So correct me if i'm wrong.
Tend to NACK.

@maflcko
Copy link
Member Author

maflcko commented Jan 20, 2016

I created this pull to see what other opinions exist.

Basically, changing the defaults to work around bugs is not the right way. Instead the wallet code should select coins more intelligent to prevent large transactions and also prevent combining inputs from many different addresses.

@maflcko
Copy link
Member Author

maflcko commented Jan 20, 2016

A one-line adjustment for 0.12 with something like CENT/10 could make sense in the short term, though.

I plan to address the wallet code changes until 0.13 or 0.14.

@jonasschnelli
Copy link
Contributor

[...] A one-line adjustment for 0.12 with something like CENT/10

Agree. But not sure about 0.12. Rc1 is already out and we might want to keep the existing MIN_CHANGE behavior in 0.12.

@maflcko maflcko force-pushed the MarcoFalke-2015-walletFixMinChange branch from d2f140d to fae5ea4 Compare January 20, 2016 17:15
@maflcko
Copy link
Member Author

maflcko commented Jan 20, 2016

I will think about this and open a new pull next week.

@maflcko maflcko closed this Jan 20, 2016
@maflcko maflcko deleted the MarcoFalke-2015-walletFixMinChange branch January 20, 2016 20:11
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transaction creation failed coin selection code does very badly in some cases

5 participants