Skip to content

[travis] add zmq python module, re-enable zmq rpc tests #6686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 3 commits into from
Oct 1, 2015
Merged

[travis] add zmq python module, re-enable zmq rpc tests #6686

laanwj merged 3 commits into from
Oct 1, 2015

Conversation

@jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Sep 17, 2015

Travis can't run the zmq tests because its missing the python zmq module.
https://travis-ci.org/bitcoin/bitcoin/jobs/80832394#L3588

This would install the python zmq module and re-enable the rpc tests.
Disabling zmq tests on travis would be another solution, but IMO we should maximize the CI test coverage.

Not sure if this is a good solution (@theuni?).

Let's discuss this before merging.

@sipa
Copy link
Member

sipa commented Sep 17, 2015 via email

@jgarzik
Copy link
Contributor

jgarzik commented Sep 17, 2015

ACK - is both necessary and correct

@jonasschnelli jonasschnelli force-pushed the 2015/09/travis_zmq branch 2 times, most recently from 66ff985 to e5ec7f3 Compare September 17, 2015 18:09
@jonasschnelli jonasschnelli changed the title [travis] add zmq python module [travis] add zmq python module and re-enable zmq rpc tests on travis Sep 17, 2015
@jonasschnelli jonasschnelli changed the title [travis] add zmq python module and re-enable zmq rpc tests on travis [travis] add zmq python module, re-enable zmq rpc tests Sep 17, 2015
@jonasschnelli jonasschnelli force-pushed the 2015/09/travis_zmq branch 9 times, most recently from 5d21398 to b24e306 Compare September 18, 2015 07:26
@jonasschnelli jonasschnelli changed the title [travis] add zmq python module, re-enable zmq rpc tests [travis] [please don't merge yet / under work] add zmq python module, re-enable zmq rpc tests Sep 18, 2015
@jonasschnelli jonasschnelli force-pushed the 2015/09/travis_zmq branch 3 times, most recently from c302e26 to aebecb2 Compare September 18, 2015 12:33
@btcdrak
Copy link
Contributor

btcdrak commented Sep 18, 2015

Looks like Travis timed out on a couple of jobs.

@dcousens
Copy link
Contributor

dcousens commented Sep 19, 2015

ACK

@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Sep 19, 2015

Somehow even if travis successfully installs libzmq3 and python-zmq, the rpc test can't connect over zmq with bitcoind.
Still try to figure out why...

@theuni
Copy link
Member

theuni commented Sep 22, 2015

Does this work locally? It's not clear to me what needs to be native and what needs to be per-arch.

@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Sep 22, 2015

@theuni
The zmq_test.py (RPC test) works prefect locally. Tested on OSX/Debian and Ubuntu.
The zmq_test.py changes within this PR are for debugging purposes.
I can only encounter the problem in Travis builds.
It looks like that zmq tcp:// connection does not work in travis. Even after installing python-zmq. Also my solution (sudo rm -f /etc/apt/sources.list.d/travis_ci_zeromq3-source.list;) looks after a workaround hack.
Maybe you have a different approach to get the zmq_test.py running on travis.

@maflcko maflcko mentioned this pull request Sep 22, 2015
Merged
@laanwj laanwj added the Tests label Sep 23, 2015
@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Sep 29, 2015

@theuni: Any idea how we could fix this? Having CI tests for the ZMQ would be important IMO otherwise the risks are high that things break without noticing.

@theuni
Copy link
Member

theuni commented Sep 29, 2015

@jonasschnelli I need to spend a bit of time learning about the intricacies of zmq/python here. But I'll try to track down the issue.

@theuni theuni mentioned this pull request Sep 29, 2015
Merged
@theuni
Copy link
Member

theuni commented Sep 29, 2015

@jonasschnelli This fixes: theuni@05a7243 . Problem was the old libzmq that the pyzmq was using. Installing the newer pyzmq from a ppa pulls in newer versions of both.

@jonasschnelli jonasschnelli changed the title [travis] [please don't merge yet / under work] add zmq python module, re-enable zmq rpc tests [travis] add zmq python module, re-enable zmq rpc tests Oct 1, 2015
@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Oct 1, 2015

Added @theuni commit.
Travis is happy now.
This would add CI coverage of the ZMQ feature.

@laanwj
Copy link
Member

laanwj commented Oct 1, 2015

ACK when travis is green

@laanwj laanwj merged commit 745f909 into bitcoin:master Oct 1, 2015
laanwj added a commit that referenced this pull request Oct 1, 2015
@laanwj
Merge pull request #6686
17d0e63 
745f909 travis: install a recent libzmq and pyzmq for tests (Cory Fields)
a9c27cd [travis] add zmq python module (Jonas Schnelli)
110a1fd enable zmq-test in rpc-tests.sh (Jonas Schnelli)
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Aug 24, 2016
@jonasschnelli @luke-jr
[travis] add zmq python module
16b2346 
Github-Pull: bitcoin#6686
Rebased-From: a9c27cd
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request Aug 24, 2016
@theuni @luke-jr
travis: install a recent libzmq and pyzmq for tests
5df5425 
Github-Pull: bitcoin#6686
Rebased-From: 745f909
@str4d str4d mentioned this pull request Jan 31, 2017
Merged
zkbot added a commit to zcash/zcash that referenced this pull request Feb 9, 2017
@zkbot
Auto merge of #2050 - str4d:2020-zmq, r=<try>
dd8b383 
Add ZeroMQ notifications

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6103
- bitcoin/bitcoin#6684
- bitcoin/bitcoin#6686
- bitcoin/bitcoin#6736
- bitcoin/bitcoin#6739
- bitcoin/bitcoin#6743
- bitcoin/bitcoin#6768
- bitcoin/bitcoin#6779
- bitcoin/bitcoin#6810
- bitcoin/bitcoin#6927
- bitcoin/bitcoin#6980 (only upgrading zeromq)
- bitcoin/bitcoin#6680
- bitcoin/bitcoin#7058
- bitcoin/bitcoin#7621
- bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`)
- bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`)
- bitcoin/bitcoin#7762
- bitcoin/bitcoin#7993 (only upgrading zeromq)
- bitcoin/bitcoin#8238
- bitcoin/bitcoin#8701
- bitcoin/bitcoin#6685

Closes #2020.
zkbot added a commit to zcash/zcash that referenced this pull request Feb 9, 2017
@zkbot
Auto merge of #2050 - str4d:2020-zmq, r=bitcartel
253c610 
Add ZeroMQ notifications

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#6103
- bitcoin/bitcoin#6684
- bitcoin/bitcoin#6686
- bitcoin/bitcoin#6736
- bitcoin/bitcoin#6739
- bitcoin/bitcoin#6743
- bitcoin/bitcoin#6768
- bitcoin/bitcoin#6779
- bitcoin/bitcoin#6810
- bitcoin/bitcoin#6927
- bitcoin/bitcoin#6980 (only upgrading zeromq)
- bitcoin/bitcoin#6680
- bitcoin/bitcoin#7058
- bitcoin/bitcoin#7621
- bitcoin/bitcoin#7335 (only parts affecting `zmq_test.py`)
- bitcoin/bitcoin#7853 (only parts affecting `zmq_test.py`)
- bitcoin/bitcoin#7762
- bitcoin/bitcoin#7993 (only upgrading zeromq)
- bitcoin/bitcoin#8238
- bitcoin/bitcoin#8701
- bitcoin/bitcoin#6685

Closes #2020.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jonasschnelli @sipa @jgarzik @btcdrak @dcousens @theuni @laanwj