Consolidate scattered max peer connection values into single declaration. #6503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
changed the title
Contributor
|
utACK. |
Author
|
I forget by whom, but wasn't there a previous recent effort to consolidate all constants into a single consensus header? |
Member
|
@NanoAkron This is just a network implementation constant, definitely not something consensus critical. |
Member
|
Looks good to me. |
src/net.h
Outdated
Member
There was a problem hiding this comment.
A more consistent (and correct) name would be DEFAULT_MAX_PEER_CONNECTIONS
Member
|
Similar to #6349 (but affects a different value) |
Member
|
utACK |
value of 125 into a single constant declaration.
Member
|
utACK |
sipa
added a commit
that referenced
this pull request
Aug 4, 2015
19dd40a Consolidate individual references to the current maximum peer connection value of 125 into a single constant declaration. (Matt Quinn)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 26, 2017
Tor ephemeral hidden services Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6503 (included to reduce merge conflicts) - bitcoin/bitcoin#6639 - bitcoin/bitcoin#6643 - bitcoin/bitcoin#7090 - bitcoin/bitcoin#7035 - bitcoin/bitcoin#7170 - bitcoin/bitcoin#7218 (non-QT part) - bitcoin/bitcoin#7313 - bitcoin/bitcoin#7438 - bitcoin/bitcoin#7553 - bitcoin/bitcoin#7637 - bitcoin/bitcoin#7683 - bitcoin/bitcoin#7813 - bitcoin/bitcoin#7703 - bitcoin/bitcoin#8203 - bitcoin/bitcoin#9004 - bitcoin/bitcoin#9234 - bitcoin/bitcoin#9911 (partial) Closes #2061.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are several integer literals of value 125 used to represent the maximum number of peer connections to maintain. This commit replaces those literals with a single constant defined in net.h.