Misc build fixes #6501
Merged
Misc build fixes #6501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking libcrypto for a function after we've already found a (possibly different) libcrypto is not what we want to do here. pkg-config might've found a cross lib while AC_CHECK_LIB may find a different or native one. Run a link-test against the lib that's already been found instead.
Contributor
|
ut ACK |
Member
|
Tested ACK |
laanwj
added a commit
that referenced
this pull request
Aug 3, 2015
31bfc27 build: make sure pkg-config checks are guarded by an m4_ifdef (Cory Fields) d9add71 build: fix libressl detection (Cory Fields)
str4d
pushed a commit
to str4d/zcash
that referenced
this pull request
Sep 29, 2016
Now that BIP66 passed, OpenSSL is no longer directly part of the consensus. What matters is that DER signatures are correctly parsed, and secp256k1 crypto is implemented correctly (as well as the other functions we use from OpenSSL, such as random number generation) This means that effectively, using LibreSSL is not a larger risk than using another version of OpenSSL. Remove the specific check for LibreSSL. Includes the still-relevant part of zcash#6729: make sure CHECK_HEADER is called using the right CXXFLAGS, not CFLAGS (as AC_LANG is c++). Zcash Note: This includes a code removal from d9add71 that was omitted from 5a39133 during backporting of bitcoin/bitcoin#6501 to 0.11.* in bitcoin/bitcoin#6703
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit addresses #6458 and #6432. I'm not sure if it's enough to fix it completely, but it addresses the bulk of the pkg-config issue.
The second commit (maybe) addresses #6486. I noticed it while I was looking at configure. It's not clear if #6486 is a real bug for that user or not, but either way it was prone to failure before and should work as expected after the change.