Clean up chainparams some more. #6473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
No strong opinion, but looks good to me. |
Contributor
|
ACK (makes sense to remove duplicated parameter default values and the const pass by ref). |
Member
|
I'd prefer to take this one step further: remove the default arguments from the outer |
domob1812
force-pushed
the
cleanup-chainparams
branch
from
8b4eeb2 to
032e8e5
Compare
Contributor
Author
|
I agree - I've updated the patch. When it is finally reviewed and ready, I will squash the commits. |
Member
|
utACK |
Member
|
ut ACK. Agreed that the defaults there are strange. |
Member
|
@domob1812 can you squash please? |
domob1812
force-pushed
the
cleanup-chainparams
branch
from
74e9f79 to
5fb5c9b
Compare
Contributor
Author
|
Done. |
Clean up the code in chainparams a bit more after the recent refactorings. In particular, make sure the structure of the "RegTest" params matches the structure of the other classes. This makes the code clearer to read. Also remove redundant values of the genesis block in always-specified optional arguments and mark variable/argument as "const".
laanwj
added a commit
that referenced
this pull request
Jul 31, 2015
5fb5c9b Clean up chainparams some more. (Daniel Kraft)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Jan 19, 2018
Bitcoin 0.12 chainparams cleanups Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6222 - bitcoin/bitcoin#6381 - bitcoin/bitcoin#6473 - bitcoin/bitcoin#6242 Part of #2074.
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Jan 22, 2018
Bitcoin 0.12 chainparams cleanups Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6222 - bitcoin/bitcoin#6381 - bitcoin/bitcoin#6473 - bitcoin/bitcoin#6242 Part of #2074.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the code in chainparams a bit more after the recent refactorings. In particular, make sure the structure of the "RegTest" params matches the structure of the other classes. This makes the code clearer to read.
Also remove redundant values of the genesis block in always-specified optional arguments and mark variable/argument as "const".