utACK.

utACK

There is nothing wallet-specific about the method, and in fact it is needed in P2P code in #4570 (though the IsEquivalentTo implementation there is in need of update).

@dgenr8 I was more concerned with this belonging in the consensus library than anything else. We've been trying to detach methods from the base transaction data structures esp. those not used in consensus for a while. So this was a clear step in the wrong way.

If you do want to use it outside the wallet there are other solutions. Most straightforward is to make it an utility function that is not bound to any class:

bool AreTransactionsEquivalent(const CTransaction& txa, const CTransaction& txb) const
{
   CMutableTransaction tx1 = txa;
   CMutableTransaction tx2 = txb;
   for (unsigned int i = 0; i < tx1.vin.size(); i++) tx1.vin[i].scriptSig = CScript();
   for (unsigned int i = 0; i < tx2.vin.size(); i++) tx2.vin[i].scriptSig = CScript();
   return CTransaction(tx1) == CTransaction(tx2);
}

... but I wouldn't know where exactly to put it, then. Probably with other utility functions used for policy and wallet only.

Unless you have a good suggestion where to put it now, I'd say we should move ahead with this and then you can solve the issue in #4570 (if we are still going to merge that).

Ok, no problem.

The only existing non-consensus module that is shared between wallet and main, and knows about transactions, is validationinterface.