Skip to content

Conversation

@Diapolo
Copy link

@Diapolo Diapolo commented Jun 23, 2015

  • MakeSingleColorImage() is unused in non Mac, silence the compiler
    warning

- MakeSingleColorImage() is unused in non Mac, silence the compiler
  warning
@luke-jr
Copy link
Member

luke-jr commented Jun 23, 2015

This seems unnecessarily convoluted IMO...

@Diapolo
Copy link
Author

Diapolo commented Jun 23, 2015

C'mon... @laanwj tried it, I didn't test it correctly and NOW the warning is gone. Please don't make it controversial if it works or give a better/easier solution and post a pull, thanks.

@luke-jr
Copy link
Member

luke-jr commented Jun 23, 2015

If you're going to use #if, just remove the whole function...?

@penguin1333
Copy link

I'd say to just go with it. If it removes warnings, then less confusion :)

I didn't really review the code very much, but from what is said it does, it sounds good to me.

(Again, I did not read the code. I glanced at it, nor have I tested it.)

@Diapolo
Copy link
Author

Diapolo commented Jun 23, 2015

@luke-jr Try to #if the function and see what happens then -_-.

@luke-jr
Copy link
Member

luke-jr commented Jun 23, 2015

@Diapolo Simple, see #6328

@jonasschnelli
Copy link
Contributor

Prefere #6328 because it's based on preprocessor macros.

@laanwj
Copy link
Member

laanwj commented Jul 2, 2015

NACK, neither this nor #6328 is the solution we should use here.

@laanwj laanwj closed this Jul 2, 2015
@Diapolo
Copy link
Author

Diapolo commented Jul 3, 2015

@laanwj This is weird, as your solution (current master) doesn't fix the warning, while my patch and also Lukes did fix it. My idea was to get this fixed without such a discussion...

@laanwj
Copy link
Member

laanwj commented Jul 3, 2015

@Diapolo My point in #6328 is that non-breaking platform specific style differences should be based on a runtime decision, not on #ifdefs (or maybe one set of #ifdef at the initialization of the program, which can be overridden using an option). See my post here: #6328 (comment)

@Diapolo Diapolo deleted the scicon branch August 10, 2015 12:12
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants