Fix getbalance * 0 #6276
Merged
Fix getbalance * 0 #6276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tag for 0.10 and 0.11 branches please. |
dgenr8
force-pushed
the
getbalance_fix
branch
2 times, most recently
from
d5c7efb to
c43faf9
Compare
Chance "getbalance *" not to use IsTrusted. The method and result now match the "getbalance <specific-account>" behavior. In particular, "getbalance * 0" now works. Also fixed a comment -- GetGalance has required 1 confirmation for many years, and the default "getbalance *" behavior matches that.
Contributor
|
utACK. |
|
Tested and works as expected, backporting to 0.10 requires renaming CheckFinalTx to IsFinalTx. |
Member
|
utACK |
laanwj
added a commit
that referenced
this pull request
Jun 15, 2015
7d6a85a Fix getbalance * (Tom Harding)
laanwj
pushed a commit
that referenced
this pull request
Jun 15, 2015
Chance "getbalance *" not to use IsTrusted. The method and result now match the "getbalance <specific-account>" behavior. In particular, "getbalance * 0" now works. Also fixed a comment -- GetGalance has required 1 confirmation for many years, and the default "getbalance *" behavior matches that. Github-Pull: #6276 Rebased-From: 7d6a85a
Member
|
Cherry-picked to 0.11 as c9fd907, to 0.10 as (thanks @thrasher-) c7d28ce12af216a691f7aac1ae48f11c979d604f |
laanwj
pushed a commit
that referenced
this pull request
Jun 15, 2015
Chance "getbalance *" not to use IsTrusted. The method and result now match the "getbalance <specific-account>" behavior. In particular, "getbalance * 0" now works. Also fixed a comment -- GetGalance has required 1 confirmation for many years, and the default "getbalance *" behavior matches that. Github-Pull: #6276 Rebased-From: 7d6a85a Rebased-By: @trasher-
reddink
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
May 27, 2020
Chance "getbalance *" not to use IsTrusted. The method and result now match the "getbalance <specific-account>" behavior. In particular, "getbalance * 0" now works. Also fixed a comment -- GetGalance has required 1 confirmation for many years, and the default "getbalance *" behavior matches that. Github-Pull: bitcoin#6276 Rebased-From: 7d6a85a Rebased-By: @trasher- (cherry picked from commit 0fd8464)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change "getbalance *" not to use IsTrusted. The method and result now match the "getbalance <specific-account>" behavior. In particular, "getbalance * 0" now works.
Ping @jonasschnelli, @wtogami