Discuss: unify bip70 chain names, user-facing chain strings and default dir names #6229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements related to chainparams were accumulating in #5229, but they don't need to add a new option for them to make sense, so I'm taking them ot for discussion.
Since there are several somewhat-orthogonal changes here, the scope of the PR will probably be reduced after discussion.
There are several changes:
The most controversial thing is proposing to unify some things for testnet that are already unified for regtest.
The first step would be to replace the user-facing strings (including windows' direct access names) to fit the chain names described in bip70 (use "test" instead of "testnet").
We could also unify the default name for the data directory. That would mean either change the directory file from "testnet3" to "test" (not retro-compatible) or changing the chain name "test" to "testnet3" in BIP70. I don't understand why "test" was chosen instead of "testnet" for bip70 in the first place so my preference is the later.
For the user-facing strings, that would be like having changed directly from "testnet" to "testnet3" (without passing through the current bip70-compatible "test").