[OSX] revert renaming of Bitcoin-Qt.app and use CFBundleDisplayName (partial revert of #6116) #6214
Conversation
|
Were there problems with the new name? |
|
@Diapolo the problem seems to be that there is no upgrade path for applications that change name. People will end up with two versions installed, which can be problematic.It's kind of unfortunate. |
|
@jonasschnelli had any luck with the CFBundleDisplayName? |
|
Start working on it in about 4h. |
|
Found a solution to keep the application bundle name "Bitcoin-Qt.app" while using "Bitcoin Core" as display name. I'm now forming a proper commit and test it over gitian. |
|
Very nice! |
|
Credits goes to @theuni for sketching this approach. Thanks. |
|
Glad this actually worked! What's the reason for not just adding Base.lproj/InfoPlist.strings in git, though? Looks like we were faking it before with Resources/empty.lproj, but now that we actually have something to put in there, may as well just commit the files and copy them into the bundle during creation. |
|
The nice thing with faking the file during the make process is that we not add another file containing a static string for the application name. But I agree it's a bit of a hack. There is also a problem with .DS_Store (positioning) I'd like to fix. |
jonasschnelli
force-pushed
the
2015/06/revert_renaming
branch
from
e6e064b to
e6be441
Compare
jonasschnelli
changed the title
jonasschnelli
force-pushed
the
2015/06/revert_renaming
branch
7 times, most recently
from
31c0718 to
c5773bb
Compare
|
This is PR final now Application name shows "Bitcoin Core" but the application bundles name is still "Bitcoin-Qt.app". If you drag "Bitcoin Core" to your /Applications dir, it will ask you if you like to overwrite "Bitcoin-Qt.app". Prove screens: OSX10.7 |
|
@theuni @jonasschnelli awesome work, will test shortly. |
jonasschnelli
force-pushed
the
2015/06/revert_renaming
branch
from
c5773bb to
0a32a93
Compare
There was a problem hiding this comment.
For the records: this is required so that the OS can detect a manual rename of the application. If current (manually renamed) application name is != CFBundleName, it won't use localization over Base.lproj to rename the application display name.
5 participants
Reverts the renaming of the app bundle, uses "Bitcoin Core" as CFBundleDisplayName and keeps "Bitcoin-Core" as disk image name and title.