release notes 0.11: add osx upgrader info #6212
Conversation
There was a problem hiding this comment.
Ugh, can't this be automated some way? Will people end up with two versions installed?
There was a problem hiding this comment.
The os doesn't handle this automatically. We could add something within the QT startup but i think it would be critical and risky. Some users might also like to keep the old version.
There was a problem hiding this comment.
I agree that is even messier.
I think the rename we did is a mistake if this means the user needs to do a manual action. People will accidentally keep using the wrong version. We've had this on windows at some point, too.
There was a problem hiding this comment.
Hmm... right. It is not ideal.
But either we rename the app now, with the consequence, that the user needs to delete the old app (now we are in version 0.11 which implies that such things could be necessary) or we keep the name Bitcoin-Qt.app as application bundle name.
I have to admit that it is inconsistent at the moment (OSX: "Bitcoin-Core", win/linux: "bitcoin-qt" [name of the runnable application from the enduser perspective]).
There was a problem hiding this comment.
I think the rename would have only made sense if we had renamed all bitcoin-qt binaries on all platforms (which we disagreed to because this would be to risky and without sense). I create a PR for revert the renaming of the binary (only rename the disk image)
|
Closing because of #6214 |
|
@theuni any suggestions here? |
|
It my experience testing this, it just did the "right thing" tm. Because the old/new .app's use the same identifier, the older one was hidden and only the new one shows. I made sure to test that before ACKing the name change. @jonasschnelli Does the opposite happen for you? @laanwj To clarify: Usually when you drag an updated .App do Applications, it'll replace the old one. Now, it hides the old one in the launcher and only shows the new one. The old Bitcoin-Qt is still visible in the file explorer and can be deleted. So to the average user, they click -> drag, and the new .app shows up as expected. I don't think it's a messy outcome at all. One thing I noticed is that the timestamps are nasty, because we hard-code them in gitian. Maybe bumping the gitian faketime stamps to a more current time would help to distinguish the old/new versions, especially when sorting is involved. One quick thought: the osx manifest might allow us to account for this type of movement, checking now. |
|
My concerns are more in a different direction. I think the drag'copy delete'old-app thing is not a big issue. There could be a confusing when one uses spotlight (osx search engine) or when users go over finder directly to the application dir. Here i'm trying to take the all or nothing position. Either we rename bitcoin-qt to Bitcoin-Core or "bitcoin-core-ui" or we keep it consistent with the "old" bitcoin-qt over all platforms. What made me originally think about renaming was, that "bitcoin-qt" is somehow a strange application name. Bitcoin-Core as name is nice and users can distinct "bitcoin" (technology) and "bitcoin-core" (application). Bitcoin-qt is a combination of two technologies names and therefore unsuitable as branding name for a UI application. |
3 participants
No description provided.