Aligning tests with the supply algorithm. #6191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
NACK, sorry. I do not think it is worth to touch this (the reasoning is all written in #5925). |
Member
|
How about we rename MAX_MONEY to AMOUNT_OVERFLOW_PROTECTION_THRESHOLD? Can
we do then stop discussing the precise semantics of the maximum money
constant?
|
Member
|
Fully agree with @sipa, couldn't have worded it better. |
ghost
mentioned this pull request
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring of #5925, the least we can do to follow best practices on the testing side (à la TDD, tests shouldn't be enforcing improper, consensus-conflicting, behavior).
Hence, this PR is limited to test corrections only, setting up the stage for MAX_MONEY refactoring at some future point in time as per sipa's suggestion.