Update Windows resource files (and add one for bitcoin-tx) #6098
Conversation
|
ut ACK |
luke-jr
force-pushed
the
201505_win_rc
branch
3 times, most recently
from
438f18e to
6a3dd52
Compare
|
@theuni This changes the build system to add a windows resource file, can you take a look if it's correct? |
|
Looks good to me. Travis builds and inserts these, so we can be somewhat confident that they're working as intended. utACK. |
src/bitcoind-res.rc
Outdated
There was a problem hiding this comment.
JSON-RPC is hardly the only thing it does. I would just say headless version or version without GUI.
There was a problem hiding this comment.
It's the only user interface... "headless" or "without GUI" implies it is suitable for human use.
There was a problem hiding this comment.
There was a problem hiding this comment.
I like "headless Bitcoin node". "Client" is also the wrong word to use in a P2P world.
There was a problem hiding this comment.
So... "bitcoind (Bitcoin node with a JSON-RPC server)"?
|
@luke-jr are you planning to update the name so that this can be merged? |
|
@laanwj Woops, thought I already had, sorry. Done. |
src/qt/res/bitcoin-qt-res.rc
Outdated
There was a problem hiding this comment.
Ugh, we have to client->node here to, to be consistent with the bitcoind change ("GUI Bitcoin node"?)
cc24610 Update Windows resource files (and add one for bitcoin-tx) (Luke Dashjr)
6 participants
I have not tested this at all.