Skip to content

autoprune minor post-merge improvements #6058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 2 commits into from
May 11, 2015
Merged

autoprune minor post-merge improvements #6058

laanwj merged 2 commits into from
May 11, 2015

Conversation

@jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Apr 24, 2015

  • Adds information about whether we are in pruned mode or not to RPC getblockchaininfo().
  • Produces appropriate response when trying to access a pruned block over REST and RPC.

@sipa
Copy link
Member

sipa commented Apr 24, 2015 via email

@jonasschnelli jonasschnelli mentioned this pull request Apr 24, 2015
Merged
@jonasschnelli jonasschnelli force-pushed the 2015/04/autoprune_info branch from a03a90e to f399f46 Compare April 25, 2015 18:28
@jonasschnelli jonasschnelli changed the title add autoprune information to RPC "getinfo" add autoprune information to RPC "getblockchaininfo" Apr 25, 2015
@jonasschnelli jonasschnelli force-pushed the 2015/04/autoprune_info branch 2 times, most recently from 591fcc4 to 76c2a4c Compare April 25, 2015 18:30
@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Apr 25, 2015

@sipa: right. You already told me that on IRC. My mistake, sorry.
Moved information to getblockchaininfo().

sipa
sipa reviewed Apr 26, 2015
View reviewed changes
src/rpcblockchain.cpp Outdated
Copy link
Member

@sipa sipa Apr 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're abolishing the name "autoprune". Can you just call it "pruned" or something?

@jonasschnelli jonasschnelli force-pushed the 2015/04/autoprune_info branch from 76c2a4c to 1b2e555 Compare April 26, 2015 21:23
@jgarzik
Copy link
Contributor

jgarzik commented Apr 26, 2015

ut ACK

@jonasschnelli jonasschnelli changed the title add autoprune information to RPC "getblockchaininfo" autoprune minor post-merge improvements Apr 27, 2015
@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Apr 27, 2015

Renamed and added some error handling for REST and RPC when trying to access a pruned block.

@jonasschnelli jonasschnelli force-pushed the 2015/04/autoprune_info branch from 9916fc4 to f15ef8c Compare April 27, 2015 03:32
@sipa
Copy link
Member

sipa commented Apr 27, 2015

utACK

@laanwj
Copy link
Member

laanwj commented Apr 29, 2015

utACK after @sdaftuar 's nit fixed. The error message specifically mentions "pruned", so it should be sure that's actually the case.

@jonasschnelli jonasschnelli force-pushed the 2015/04/autoprune_info branch from a4f459f to b4ce4bd Compare April 29, 2015 11:16
@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Apr 29, 2015

Agreed with @sdaftuar.
Corrected prune mode test.

@jonasschnelli jonasschnelli force-pushed the 2015/04/autoprune_info branch from b4ce4bd to 619ad6c Compare May 2, 2015 08:33
@jonasschnelli jonasschnelli force-pushed the 2015/04/autoprune_info branch from 619ad6c to 03c5687 Compare May 11, 2015 14:10
@laanwj laanwj merged commit 03c5687 into bitcoin:master May 11, 2015
laanwj added a commit that referenced this pull request May 11, 2015
@laanwj
Merge pull request #6058
7e0e7f8 
03c5687 appropriate response when trying to get a block in pruned mode (Jonas Schnelli)
1b2e555 add autoprune information to RPC "getblockchaininfo" (Jonas Schnelli)
@jonasschnelli jonasschnelli mentioned this pull request May 14, 2015
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonasschnelli @sipa @jgarzik @laanwj