MOVEONLY-ish: Move most block header validation function defintions to consensus/blockverify.cpp #6048
Conversation
jtimon
changed the title
jtimon
changed the title
|
Closing until #5696 is resolved |
jtimon
force-pushed
the
consensus_header0
branch
from
5505a8a to
502f337
Compare
jtimon
force-pushed
the
consensus_header0
branch
from
502f337 to
699f550
Compare
jtimon
changed the title
jtimon
changed the title
|
Reopened as independent from #5696 |
|
NACK. Why? #5696 has several ACKs and is likely to be merged very quickly. Those changes have gone through half a dozen iterations, but never been merged because they're constantly moving in and out of PRs. Now you've tacked it on to something else that will need more review, essentially putting the brakes on it again. Worse yet, it fails to build. Please, just wait for one chunk at a time. This is getting out of hand. |
(declarations to consensus/consensus.h) from main.cpp: -CheckBlockHeader -ContextualCheckBlockHeader -IsSuperMajority from pow.cpp: -CalculateNextWorkRequired -CheckProofOfWork -GetNextWorkRequired
jtimon
force-pushed
the
consensus_header0
branch
from
699f550 to
0d486be
Compare
|
I'm sorry, I just wanted to show that this (and everything necessary to expose VerifyHeader) is independent from #5696, from whether MANDATORY_SCRIPT_VERIFY_FLAGS is consensus, policy, or none of them. And if the includes in #5696 (not so many now that the policy stuff is left out) trigger a rebase (like they have done many times before), this could still not need rebase and have an older commit ID the replacement of jtimon@691161d. About the building error, I don't know why forgetting .h files in the makefile doesn't fail in my computer, but fixed. Anyway, even if it's independent from #5696, merging one would trigger a trivial rebase on the other, so closing until #5696 and #5975. |
|
Try "make distcheck", which builds a source package abd rebuilds from that.
If you don't do that (and this has bitten me as well), you risk that the
build uses files from the repository which are not listed as source files
in the build system.
|
|
Thank you @sipa . Oh, I forgot to actually close the PR |
3 participants
Right after #5975 is merged I would open this PR so I think it makes sense to open it already in case both things can be merged at once, and also to simplify #6051 dependecies.
Note that this is no longer depedendent on #5696 nor #5669