Cleaned up critical section code. #602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I like this; it uses the proper c++ idiom (RAII) which is more readable and potentially more robust. Can you add testcase/unittest? |
Author
|
Done. Thanks. |
Contributor
|
ACK |
Contributor
|
It would be nice to test that Critical section code actually works by spawning threads and testing locks in the test suite. |
Contributor
|
I'm going to merge this early-- writing multithreaded unit tests would be spiffy, but second-best is to merge early and get lots of testing. |
gavinandresen
added a commit
that referenced
this pull request
Nov 21, 2011
Cleaned up critical section code.
coblee
referenced
this pull request
in litecoin-project/litecoin
Jul 17, 2012
Cleaned up critical section code.
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Aug 19, 2017
Port parallel execution of rpc tests
kallewoof
pushed a commit
to kallewoof/bitcoin
that referenced
this pull request
Oct 4, 2019
… RPC b919ca3 fedpeg test makes sure claim_script is wpkh (Gregory Sanders) a9cbe55 refactor getpeginaddress to not call getnewaddress RPC (Gregory Sanders) cdb33e5 createrawpegin should look for wpkh addresses, not nested (Gregory Sanders) Pull request description: resolves ElementsProject/elements#599 Tree-SHA512: 37fbcb865df78337827b44fed00e54fcd5c44eea57bf48d66416be00c915129dcc5f5fda613d9f64fdb325303c24fab4a1e8b1c96fd54ee2dcaac90ba841bfb7
rajarshimaitra
pushed a commit
to rajarshimaitra/bitcoin
that referenced
this pull request
Aug 5, 2021
node_operations.asciidoc: -m is needed for 'useradd' to work
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using an ugly loop hack that swallows break and continue, I have replaced it with a simple if statement.
Please comment and/or apply!