Set nSequenceId when a block is fully linked #6010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK
|
Also adds a test to CheckBlockIndex
sdaftuar
force-pushed
the
fix-equal-work-chain-selection
branch
from
9abac5d to
c1ecee8
Compare
Member
Author
|
Added a CheckBlockIndex test and squashed. |
Member
There was a problem hiding this comment.
Won't the new test fail on older installs, which may have already sequence numbers assigned to blocks that aren't linked?
Member
There was a problem hiding this comment.
nSequence id's are memory-only; they are not stored on disk.
Member
|
utACK |
laanwj
added a commit
that referenced
this pull request
Apr 20, 2015
c1ecee8 Set nSequenceId when a block is fully linked (Suhas Daftuar)
Member
|
Cherry-picked to 0.10 via bac6fca |
Contributor
|
tested (basic operating tests) ACK. |
reddink
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Jul 11, 2020
Also adds a test to CheckBlockIndex Conflicts: src/main.cpp Rebased-From: c1ecee8 Github-Pull: bitcoin#6010 (cherry picked from commit bac6fca) # Conflicts: # src/main.cpp
reddink
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Jul 14, 2020
Also adds a test to CheckBlockIndex Conflicts: src/main.cpp Rebased-From: c1ecee8 Github-Pull: bitcoin#6010 (cherry picked from commit bac6fca) # Conflicts: # src/main.cpp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the assignment of nSequenceId for headers-first, which can result in blocks being downloaded out of order.