consensus: don't use arith_uint256 in consensus.h #6000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requiring arith_uint256 at such a base level is not good for modularity.
Contributor
|
ut ACK |
Member
|
utACK |
Contributor
|
ut ACK |
Member
|
#6000 ! |
laanwj
added a commit
that referenced
this pull request
Apr 13, 2015
fd31199 consensus: don't use arith_uint256 in consensus.h (Cory Fields)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring arith_uint256 at such a base level is not good for modularity.
@jtimon: Sorry, this may be a pain in the ass for you as it'll mean adapting some of your other PRs, but since this is already causing indirect issues in #5995, I think it's better to get this in first.