Chainparams: Refactor: Remove redundant AllowMinDifficultyBlocks() getter #5998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
src/miner.h
Outdated
Member
|
ut ACK other than the nit. |
Member
|
ut ACK |
jtimon
force-pushed
the
params_mindiff
branch
2 times, most recently
from
d6bcc6a to
bce7b6e
Compare
Contributor
Author
|
nit (forward declaration of Consensus::Params) fixed |
src/miner.h
Outdated
Member
There was a problem hiding this comment.
I don't agree on removing the argument names here, they serve as a kind of documentation.
Member
|
utACK apart from above nit |
Contributor
Author
|
Fixed @laanwj 's nit (do not remove the parameter names of the functions in the header file). |
There was a problem hiding this comment.
Nit: If you mind add a new-line here, but that's not meant to be of any interrest if this is going to get merged now :).
laanwj
added a commit
that referenced
this pull request
Apr 15, 2015
bebe728 Chainparams: Refactor: Remove redundant AllowMinDifficultyBlocks() getter (Jorge Timón)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small part of #5970.