[Qt] Clarify: smartfee button name "Minimize" #5973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
SGTM. |
Member
|
This was already discussed somewhat in #5801, and resulted in moving the button away from Transaction Fee. |
Member
|
Agree on concept. I'd suggest just making it 'Hide'. This saves translators some work, what it hides should be clear from the context. |
Make clear this button hides the options instead of minimizing the transaction fee.
Member
Author
|
Now, it is "Hide" instead of "Hide options". (Squashed the commit) |
Contributor
|
ACK. OSX Screen: |
Member
|
Looks good now. ACK. |
laanwj
added a commit
that referenced
this pull request
Apr 8, 2015
6c35664 [Qt] Clarify: smartfee button name "Minimize" (MarcoFalke)
Member
|
Post merge ACK |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned earlier by @luke-jr in #5200 the "Minimize" button can be mistakenly assumed to minimize the fee. Though, the tool tip makes it clear that the button shrinks the dialog, I'd still prefer a non ambiguous label.