Use GetAncestor to compute new target #5948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Looks good to me. This assert could even be left out as GetAncestor already returns NULL for heights <0.
Member
Author
There was a problem hiding this comment.
To mimick the exact old code, it would need to be nHeightFirst = std::max(0, pindex->nHeight - (... - 1));. I added the assert to be sure for now that dropping the std::max is safe (which it should be afaict).
Member
|
Going to test this on my test node. |
Member
|
Tested ACK |
sipa
added a commit
that referenced
this pull request
Apr 7, 2015
1cc0e96 Trivial optimization: use GetAncestor to compute new target (Pieter Wuille)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't expect a measurable performance improvement from this, but result seems more readable too.