Reinitialize state in between individual unit tests. #5852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tested with valgrind: zero memory leaks in test_bitcoin. |
This changes the TestingSetup fixture to be per-unit-test rather than global. Most tests don't need it, so it's only invoked in a few.
Member
Author
|
@gavinandresen ping |
Contributor
|
Code review ACK-- very nice! I'll re-implement the #5835 unit test on top of this after lunch, to test. |
Contributor
|
ACK. Tested by reimplementing unit test of #5835 with a REGTEST-mode 100-block chain. |
Member
|
utACK |
laanwj
added a commit
that referenced
this pull request
Mar 9, 2015
51598b2 Reinitialize state in between individual unit tests. (Pieter Wuille)
This was referenced Jan 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.