keys: remove libsecp256k1 verification until it's actually supported #5839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK. |
Member
|
This doesn't remove support from configure.ac, is that intentional? |
Member
|
utACK. I like to test around with secp256k1, but it's just as easy to patch it back in instead of fixing it up. |
theuni
force-pushed
the
remove-libsecp256k1-verification
branch
2 times, most recently
from
63073f9 to
16a58a8
Compare
This was added a while ago for testing purposes, but was never intended to be used. Remove it until upstream libsecp256k1 decides that verification is stable/ready.
Member
Author
|
@sipa Thanks, I didn't realize those bits were still around. Nuked those as well as the ones in Makefile.am. |
Member
|
reutACK |
sipa
added a commit
that referenced
this pull request
Mar 3, 2015
16a58a8 keys: remove libsecp256k1 verification until it's actually supported (Cory Fields)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added a while ago for testing purposes, but was never intended to be used. Remove it until upstream libsecp256k1 decides that verification is stable/ready.
Because it appears as though it's optional for use, there have been several efforts to clean it up and get it back in working order. See #5837 #5838 #5811 for examples.
Until this is actually intended to be used, remove it to remove the temptation.