Skip to content

Conversation

@fanquake
Copy link
Member

Original placement seems to be causing some confusion among users.
Before
screen shot 1

After
screen shot 3

@paveljanik
Copy link
Contributor

Why do you change various width and height?

@fanquake
Copy link
Member Author

As far as I can workout, without those height/width changes the fee dialog box is no longer minimised when opening the Send tab, which would be altering the current behaviour. @jonasschnelli Can you take a look?

@laanwj laanwj added the GUI label Feb 19, 2015
@laanwj
Copy link
Member

laanwj commented Feb 19, 2015

Height and width values should have no impact at all on being minimized (or hidden in Qt language). If they do, I'm afraid something is buggy.

@jonasschnelli
Copy link
Contributor

@fanquake i will have a look at this as soon as im back from vacation (around 5th of march).

@fanquake
Copy link
Member Author

Updated to remove height/width changes.

@laanwj
Copy link
Member

laanwj commented Feb 20, 2015

I disagree with adding more text to the button "Minimize"->"Minimize fee dialog".

  • At best, the user would think What is the fee dialog?
  • Do we want to use the word 'dialog' in user facing messages at all? This is a UI design term not in general use.

This would be the rare case where a simple 'x' icon would be more descriptive than any amount of text.

@fanquake
Copy link
Member Author

I don't mind either way, if an X would be better lets use that. It just needs to be changed from what it is currently.

@laanwj
Copy link
Member

laanwj commented Feb 20, 2015

I'm fine with just moving the button, just not adding more text to it. The context should be enough to tell what it minimizes.

Its original placement was causing confusion among some users.
@fanquake
Copy link
Member Author

@laanwj Updated

@laanwj laanwj merged commit de5403f into bitcoin:master Feb 26, 2015
laanwj added a commit that referenced this pull request Feb 26, 2015
de5403f [GUI] Move fee dialog minimise button away from "Transaction Fee" (Michael Ford)
@fanquake fanquake deleted the move_fee_minimize branch May 12, 2016 14:20
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants