-
Notifications
You must be signed in to change notification settings - Fork 38.7k
[GUI] Move fee dialog minimise button away from "Transaction Fee:" #5801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Why do you change various width and height? |
|
As far as I can workout, without those height/width changes the fee dialog box is no longer minimised when opening the Send tab, which would be altering the current behaviour. @jonasschnelli Can you take a look? |
|
Height and width values should have no impact at all on being minimized (or hidden in Qt language). If they do, I'm afraid something is buggy. |
|
@fanquake i will have a look at this as soon as im back from vacation (around 5th of march). |
a17096f to
974915b
Compare
|
Updated to remove height/width changes. |
|
I disagree with adding more text to the button "Minimize"->"Minimize fee dialog".
This would be the rare case where a simple 'x' icon would be more descriptive than any amount of text. |
|
I don't mind either way, if an X would be better lets use that. It just needs to be changed from what it is currently. |
|
I'm fine with just moving the button, just not adding more text to it. The context should be enough to tell what it minimizes. |
Its original placement was causing confusion among some users.
974915b to
de5403f
Compare
|
@laanwj Updated |
de5403f [GUI] Move fee dialog minimise button away from "Transaction Fee" (Michael Ford)
Original placement seems to be causing some confusion among users.

Before
After
