Skip to content

Conversation

@shaulkf
Copy link
Contributor

@shaulkf shaulkf commented Feb 17, 2015

Rename following discussion in #5739 (comment)

@shaulkf
Copy link
Contributor Author

shaulkf commented Feb 17, 2015

Tests are passing locally. Does anyone know of a way to locally reproduce the Travis environment?

@paveljanik
Copy link
Contributor

read-ACK.
The Travis bug seems to be random.

@laanwj
Copy link
Member

laanwj commented Feb 18, 2015

Very much agree with this, but won't ACK unless it at least passes travis. I'll look into it.

The failure in https://travis-ci.org/bitcoin/bitcoin/jobs/51080203 is triggered by the comparison tool detecting that the node disconnected

02:07:41 14 BitcoindComparisonTool$1.onPeerDisconnected: bitcoind node disconnected!

The subsequent log however shows that the tool is the one that disconnects, and then a normal shutdown procedure follows.

2015-02-17 14:07:42 socket closed
2015-02-17 14:07:42 disconnecting peer=1
2015-02-17 14:07:42 Shutdown: In progress...

It's hard to filter out what is happening with the amount of lock-related low-level noise in that log. It may be. It may be that the interesting part of the log precedes that part of the tail that is printed ....

@laanwj
Copy link
Member

laanwj commented Feb 18, 2015

The travis respin made it pass. There's nothing in this change that could believably introduce intermittent errors, so ACK.

@fanquake
Copy link
Member

ACK

@laanwj laanwj merged commit e5ece05 into bitcoin:master Feb 18, 2015
laanwj added a commit that referenced this pull request Feb 18, 2015
e5ece05 Rename Interval() to DifficultyAdjustmentInterval() (Shaul Kfir)
@shaulkf shaulkf deleted the rename-difficulty-adjustment branch March 17, 2015 01:35
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants